remove code to add artifacts incrementally #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
iliana
approved these changes
Aug 22, 2025
sunshowers
deleted the
sunshowers/spr/remove-code-to-add-artifacts-incrementally
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our production users construct and then assemble a manifest, and that approach has proven to be easier to work with than incremental additions. Significant parts of the code can be made simpler this way, since they no longer need to construct a view of what's in the TUF repo by parsing the files contained in them.
The tufaceous binary now consists of just the assemble and extract commands. (We still use the binary in some tests, and it is convenient to have in general.)
I patched this change into Omicron and verified that it built and passed update-related tests successfully.