Make Host Phase 1 Cosmo aware #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
approved these changes
Sep 19, 2025
Comment on lines
+115
to
+119
| /// Gimlet Host phase 1 identifier. | ||
| /// | ||
| /// Derived from [`KnownArtifactKind::Host`]. | ||
| pub const HOST_PHASE_1: Self = Self::from_static("host_phase_1"); | ||
| pub const GIMLET_HOST_PHASE_1: Self = | ||
| Self::from_static("gimlet_host_phase_1"); |
Collaborator
There was a problem hiding this comment.
Worth noting that if we had any long-running systems that had imported updates into the database, changing this name would break those. But we don't so this is fine.
Collaborator
Author
There was a problem hiding this comment.
Yeah my hope is to make any changes we need right now so we don't run into that later
Cosmo sleds need a separate host phase 1 image. Make the host extraction aware of this.
labbott
force-pushed
the
cosmo_awareness
branch
from
309fd84 to
21b1d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmo sleds need a separate host phase 1 image. Make the host extraction aware of this.