upgrade tls and fix breaking changes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabiede
force-pushed
the
feature/upgrade-tls
branch
7 times, most recently
from
04f8c14 to
f746778
Compare
…s, run formatter, add ocaml versions for CI
mabiede
force-pushed
the
feature/upgrade-tls
branch
from
f746778 to
2a97f55
Compare
|
Happy new Year! Any update on this? @mikonieminen @aronerben @joseferben |
|
@mabiede Hi, sorry for the delay and likewise happy new year :) Do you just need it merged? Or anything else? |
|
@aronerben thanks, new version would be good as there are breaking changes. |
|
@joseferben Could you take care of the new version? |
|
happy new year! i'll create a release in the evening today, thanks for the pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking tls changes:
- https://github.com/oxidizing/letters/compare/master...mabiede:letters:feature/upgrade-tls?expand=1#diff-2850342db4c9d592e3d08491146e2f0bb872dbe903fd3ba3eb8c36fbfb36a9caR59
- https://github.com/oxidizing/letters/compare/master...mabiede:letters:feature/upgrade-tls?expand=1#diff-2850342db4c9d592e3d08491146e2f0bb872dbe903fd3ba3eb8c36fbfb36a9caR113
@aronerben @mikonieminen, please update with new version, thanks