Skip to content

feat: one phase search#360

Draft
forshev wants to merge 1 commit intomainfrom
0-one-phase-search
Draft

feat: one phase search#360
forshev wants to merge 1 commit intomainfrom
0-one-phase-search

Conversation

@forshev
Copy link
Contributor

@forshev forshev commented Feb 20, 2026

Description

This is a prototype of a 'one phase search'.
Add a new store method that searches docs' ids and returns stream of documents

We need this to implement search based on non-indexed fields later


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@forshev forshev self-assigned this Feb 20, 2026
@forshev forshev added the feature New feature or request label Feb 20, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 3.04183% with 255 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.26%. Comparing base (8aefcc9) to head (4918b79).

Files with missing lines Patch % Lines
proxyapi/grpc_one_phase_search.go 0.00% 97 Missing ⚠️
storeapi/grpc_one_phase_search.go 0.00% 68 Missing ⚠️
proxy/search/one_phase_search.go 0.00% 59 Missing ⚠️
storeapi/client.go 0.00% 25 Missing ⚠️
storeapi/grpc_fetch.go 53.84% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   71.42%   70.26%   -1.17%     
==========================================
  Files         205      208       +3     
  Lines       14910    15163     +253     
==========================================
+ Hits        10650    10654       +4     
- Misses       3484     3734     +250     
+ Partials      776      775       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggWide/size=10000-4 8aefcc afad98
47761.00 ns/op 58671.00 ns/op 1.23 🔴
AggWide/size=1000000-4 8aefcc afad98
516.00 B/op 623.00 B/op 1.21 🔴
5419714.00 ns/op 6613404.00 ns/op 1.22 🔴
FindSequence_Random/small-4 8aefcc afad98
6638.44 MB/s 5400.47 MB/s 0.81 🔴

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggDeep/size=1000-4 8aefcc 5e2344
4817.00 ns/op 5772.00 ns/op 1.20 🔴
AggDeep/size=1000000-4 8aefcc 5e2344
4837044.00 ns/op 5950444.00 ns/op 1.23 🔴
AggWide/size=10000-4 8aefcc 5e2344
47761.00 ns/op 57932.00 ns/op 1.21 🔴
FindSequence_Random/small-4 8aefcc 5e2344
6638.44 MB/s 5084.65 MB/s 0.77 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants