Draft
Conversation
Contributor
|
❌ PR Title Validation Failed |
1 similar comment
Contributor
|
❌ PR Title Validation Failed |
Member
Author
|
@seqbenchbot list |
|
Nice, @dkharms Here is the list of currently running benchmarks:
Have a great time! |
Member
Author
|
@seqbenchbot down 74abf34c |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
@seqbenchbot up main bulk |
Member
Author
|
@seqbenchbot down fd66c3b4 |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
❌ PR Title Validation Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Something I wanted to try for a quite long time.
For now, this implementation does not handle case-sensitivity (at least it passes
TestTokenizeSimpletest) and does not handle non-ascii sequences.And the most annoying thing -- CGO call overhead. For small strings it introduces a noticeable overhead (around 20ns to 40ns).
However, for long strings we get 20% speedup:
So I guess the right move is to wait until SIMD API will be stabilized (hopefully, in Go 1.27) and rewrite logic using intrinsics Golang provides.
If you have used LLM/AI assistance please provide model name and full prompt: