fix: correct default value for max_memory.#284
Conversation
The other does not compile.
There was a problem hiding this comment.
Code Review
This pull request corrects a TOML syntax error in a commented-out example within config.default.toml by replacing colons with equals signs in an inline table. The review feedback suggests applying this same correction to the configuration description in src/heretic/config.py for consistency and recommends adding spaces within the curly braces to improve readability.
config.default.toml
Outdated
|
|
||
| # Maximum memory to allocate per device. | ||
| # max_memory = {"0": "20GB", "cpu": "64GB"} | ||
| # max_memory = {"0" = "20GB", "cpu" = "64GB"} |
There was a problem hiding this comment.
The fix correctly addresses the TOML syntax error in the example (inline tables in TOML must use = for key-value pairs). However, the same incorrect example (using : instead of =) is present in the description of the max_memory field in src/heretic/config.py (line 122). To ensure consistency and correct documentation/CLI help, that file should also be updated.
Additionally, adding spaces inside the curly braces is more idiomatic for TOML inline tables and improves readability.
| # max_memory = {"0" = "20GB", "cpu" = "64GB"} | |
| # max_memory = { "0" = "20GB", "cpu" = "64GB" } |
|
Thanks! See the suggestion from Gemini. |
|
Merged, thanks! |
|
I am getting this: Am I missing something? |
|
That's not valid shell syntax. You probably need to wrap everything in quotes, but even that may not be enough. |
|
Yes, if I remember correctly wrapping it in single quotes does work. |
You right! this worked for me: thanks |
This is just a typo / quick fix.
The other does not compile.