Skip to content

Commit

Permalink
always clear identity cache when logging in (#128)
Browse files Browse the repository at this point in the history
This PR removes a minor optimization which was causing an endless
recursive loop, every time a user logs in we'll reset their identity
cache.
  • Loading branch information
GGonryun authored Oct 4, 2024
1 parent d0e583c commit 4d92c55
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/commands/login.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
IDENTITY_CACHE_PATH,
IDENTITY_FILE_PATH,
authenticate,
loadCredentials,
} from "../drivers/auth";
import { doc, guard } from "../drivers/firestore";
import { print2 } from "../drivers/stdio";
Expand Down Expand Up @@ -45,12 +44,8 @@ export const login = async (
if (!loginFn) throw "Unsupported login for your organization";

const tokenResponse = await loginFn(orgWithSlug);
// if the user changed their org, clear any cached identities this prevents
// commands like `aws assume role` from using the old identities
const currentIdentity = await loadCredentials().catch(() => undefined);
if (currentIdentity?.org.slug !== args.org) {
await clearIdentityCache();
}

await clearIdentityCache();
await writeIdentity(orgWithSlug, tokenResponse);

// validate auth
Expand Down

0 comments on commit 4d92c55

Please sign in to comment.