Add tickets to TODOs

p0-security · Nov 21, 2024 · fa0ec8b · fa0ec8b
1 parent 108a904
commit fa0ec8b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/commands/scp.ts b/src/commands/scp.ts
@@ -84,8 +84,7 @@ const scpAction = async (args: yargs.ArgumentsCamelCase<ScpCommandArgs>) => {
     : [];
   args.sshOptions = sshOptions;
 
-  // Azure SSH currently doesn't support specifying a port; throw an error if one is set. Azure Bastion only supports
-  // port 22 for SSH connections.
+  // TODO(ENG-3142): Azure SSH currently doesn't support specifying a port; throw an error if one is set.
   if (
     args.provider === "azure" &&
     sshOptions.some((opt) => opt.startsWith("-P"))

diff --git a/src/commands/ssh.ts b/src/commands/ssh.ts
@@ -89,8 +89,7 @@ const sshAction = async (args: yargs.ArgumentsCamelCase<SshCommandArgs>) => {
     : [];
   args.sshOptions = sshOptions;
 
-  // Azure SSH currently doesn't support specifying a port; throw an error if one is set. Azure Bastion only supports
-  // port 22 for SSH connections.
+  // TODO(ENG-3142): Azure SSH currently doesn't support specifying a port; throw an error if one is set.
   if (
     args.provider === "azure" &&
     sshOptions.some((opt) => opt.startsWith("-p"))

diff --git a/src/plugins/azure/ssh.ts b/src/plugins/azure/ssh.ts
@@ -64,8 +64,9 @@ export const azureSshProvider: SshProvider<
   reproCommands: () => undefined,
 
   setup: async (request) => {
-    // TODO: Does this specifically need to be the subscription ID for the Bastion?
+    // TODO(ENG-3129): Does this specifically need to be the subscription ID for the Bastion?
     await azLogin(request.subscriptionId); // Always re-login to Azure CLI
+
     const { path: keyPath, cleanup: sshKeyPathCleanup } =
       await createTempDirectoryForKeys();
     await generateSshKeyAndAzureAdCert(keyPath);