ENG-2660 Add a message once SSH connection is established #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a message once an SSH connection is established, if the -N option (no remote command) is used.
nbrahms
reviewed
Sep 30, 2024
Comment on lines
+188
to
+193
| const googleLoginMatch = chunkString.match(GOOGLE_LOGIN_MESSAGE); | ||
| isGoogleLoginException = isGoogleLoginException || !!googleLoginMatch; // once true, always true | ||
| if (isGoogleLoginException) { | ||
| // always overwrite to false so we don't retry the access | ||
| isEphemeralAccessDeniedException = false; | ||
| } |
There was a problem hiding this comment.
Can we keep this GCP-specific logic within the GCP-specific SSH provider? We should ensure separation of concerns, and keep anything CSP-specific within that provider's plugin.
I know this is just a code move, but we should clean up as we go along.
| * This works because AWS SSM wraps the session in a single-stream pty, so we | ||
| * do not capture stderr emitted from the wrapped shell session. | ||
| */ | ||
| const accessPropagationGuard = ( |
There was a problem hiding this comment.
What's the motivation to remove the sub-functioning for this PR? IMO the code is significantly easier to follow when it's more modular.
fabgo
deleted the
fabian/eng-2660-add-established-connection-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a message once an SSH connection is established, if the -N option (no remote command) is used.