refactor: Separate CSP-specific functionality from generic SSH code #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For maintainability, anything CSP-specific for SSH should be contained within the CSP's SSH provider object.
fabgo
approved these changes
Oct 1, 2024
| { pattern: /Permission denied \(publickey\)/ }, | ||
| { | ||
| // The output of `sudo -v` when the user is not allowed to run sudo | ||
| pattern: /Sorry, user .+ may not run sudo on .+/, |
There was a problem hiding this comment.
Useful to keep the existing constants I think, as they may be used elsewhere. I am making a change which relies on this string for example.
There was a problem hiding this comment.
Let's introduce that in the PR that actually reuses it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For maintainability, anything CSP-specific for SSH should be contained within the CSP's SSH provider object.
I also sorted the provider properties.