Print spinners during backend interaction #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we provide no user feedback whilst we contact the P0 backend. This makes it difficult for the user to distinguish between waiting on a backend response and a hung process. Use a yarn-style Unicode spinner to indicate that the process is still live.
|
This is coooooool! 🥳 |
GGonryun
approved these changes
Oct 1, 2024
fabgo
reviewed
Oct 1, 2024
| export const spinUntil = async <T>(message: string, promise: Promise<T>) => { | ||
| let isDone = false; | ||
| let ix = 0; | ||
| void promise.finally(() => (isDone = true)).catch(() => {}); |
There was a problem hiding this comment.
Should we swallow errors here?
There was a problem hiding this comment.
The errors are thrown on line 77
fabgo
approved these changes
Oct 1, 2024
nbrahms
force-pushed
the
nathan/spinner
branch
from
01ca0b6 to
a6b2b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we provide no user feedback whilst we contact the P0 backend. This makes it difficult for the user to distinguish between waiting on a backend response and a hung process.
Use a yarn-style Unicode spinner to indicate that the process is still live.
Screen.Recording.2024-10-01.at.3.02.41.PM.mov