Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always clear identity cache when logging in #128

Merged
merged 1 commit into from
Oct 4, 2024
Merged

always clear identity cache when logging in #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/commands/login.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
IDENTITY_CACHE_PATH,
IDENTITY_FILE_PATH,
authenticate,
loadCredentials,
} from "../drivers/auth";
import { doc, guard } from "../drivers/firestore";
import { print2 } from "../drivers/stdio";
Expand Down Expand Up @@ -45,12 +44,8 @@ export const login = async (
if (!loginFn) throw "Unsupported login for your organization";

const tokenResponse = await loginFn(orgWithSlug);
// if the user changed their org, clear any cached identities this prevents
// commands like `aws assume role` from using the old identities
const currentIdentity = await loadCredentials().catch(() => undefined);
if (currentIdentity?.org.slug !== args.org) {
await clearIdentityCache();
}

await clearIdentityCache();
await writeIdentity(orgWithSlug, tokenResponse);

// validate auth
Expand Down
Loading