Conversation
nbrahms
approved these changes
Oct 25, 2024
Comment on lines
+19
to
+21
| async () => { | ||
| await createKeyPair(); | ||
| } |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| async () => { | |
| await createKeyPair(); | |
| } | |
| createKeyPair |
Contributor
Author
There was a problem hiding this comment.
createKeyPair has a return value so we have to do this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command can be used if user only wants to create the key pair for SSH. One use case when user requests access through Slack instead of through the CLI and they need to provide the public key in Slack.
The command could be extended to force regeneration of the key pair. I did not include that option because already provisioned keys would not work anymore.