ENG-2960 Read ssoProvider from config host, not p0-prod #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reads the ssoProvider for login from the host specified in the config, instead of defaulting to p0-prod.
| publicDoc(`orgs/${args.org}`) | ||
| ); | ||
| await saveConfig(args.org); | ||
| await initializeFirebase(); |
There was a problem hiding this comment.
I don't follow why we need to add initializeFirebase here/. Wasn't it already initialized if we were able to read the doc before?
There was a problem hiding this comment.
There are two Firebase, the bootstrap one (which is configured to point to p0-prod) and the regular one, which uses whatever is specified in the config.
| export async function saveConfig(orgId: string) { | ||
| const orgDoc = await getDoc<RawOrgData, object>( | ||
| bootstrapDoc(`orgs/${orgId}`) | ||
| ); |
There was a problem hiding this comment.
Should there be the null check if (!orgData) throw here as well?
We wouldn't want to write the config if there was no org found I assume
There was a problem hiding this comment.
It's there on line 33. We use the bootstrap config if no config was found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads the ssoProvider for login from the host specified in the config, instead of defaulting to p0-prod.