SSH requesting access message

[MichaelDimitras]

This PR makes two changes to the status messages we use for SSH requests in the CLI.

1. Replaces the "Requesting access" status message with a more generic "Checking for access in P0"
2. Adds the message "Existing access found. Connecting to node." in the scenario where a user had access approved previously and is waiting to be connected to the node. Previously we showed nothing.

This only affects p0 ssh <destination> and p0 scp <destination>. It does not affect any p0 request flows.

Before:

4333.mov

After:

11111.mov

Addresses: https://linear.app/p0-security/issue/ENG-2827/requesting-access-spinner-is-displayed-when-it-shouldnt

[GGonryun]

should this be dependent on the type union? "all" | "approval-required" | "none"

So if we see: "approval-required" we can still say: "requesting access" 🤔

[MichaelDimitras]

Since "approval-required" is hardcoded for the ssh session request, I don't think we can use it to change the message in this case. I think the request would still have approval-required even if the user already had been approved in the past?

https://github.com/p0-security/p0cli/pull/137/files#diff-c16738fe5df540e2a49c613e959ebaa27241c6ce8389095b737f76c65bc44f8eL125

[GGonryun]

I see, I see 🤔 .

[gergas3]

You can make it dependent like this:

const accessMessage = (message?: string) => {
  switch (message) {
    case "approval-required":
      return "Requesting access";
    default:
      return "Requesting access";
  }
};

then here

Suggested change

	options?.accessMessage ? options.accessMessage : "Requesting access",
	accessMessage(options?.message),,

[MichaelDimitras]

I made this change, but the "approval-required" message type will return an accessMessage of Checking for access in P0.

This makes this change apply to p0 kubeconfig as well which I think is desirable since it's similar flow to starting an ssh session.

const accessMessage = (message?: string) => {
  switch (message) {
    case "approval-required":
     return "Checking for access in P0";;
    default:
      return "Requesting access";
  }
};

[gergas3]

You can make it dependent like this:

const accessMessage = (message?: string) => {
  switch (message) {
    case "approval-required":
      return "Requesting access";
    default:
      return "Requesting access";
  }
};

then here

Suggested change

	options?.accessMessage ? options.accessMessage : "Requesting access",
	accessMessage(options?.message),,