Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update existing SSH permission requests to match new backend data structures #140

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Update existing SSH permission requests to match new backend data structures #140

merged 8 commits into from
Nov 15, 2024

Conversation

GGonryun
Copy link
Contributor

@GGonryun GGonryun commented Nov 13, 2024 •
edited
Loading

This PR changes the permission request data structures for AWS, Azure, and Google Cloud SSH to be in line with our most recent changes to the P0 backend.

These change impact the construction of SSH commands. This latest version is necessary to continue making valid SSH requests.

@GGonryun GGonryun force-pushed the miguelcampos/eng-2988-cli-update-type-parameters-to-support-new-ssh-requests branch from ce625a7 to 9d7d5ea Compare November 13, 2024 21:52
@GGonryun GGonryun self-assigned this Nov 13, 2024
@GGonryun GGonryun marked this pull request as ready for review November 14, 2024 00:35
p0-andrewa
p0-andrewa reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@p0-andrewa p0-andrewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small style nit/question.

src/plugins/google/types.ts Outdated Show resolved Hide resolved
p0-andrewa
p0-andrewa approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@p0-andrewa p0-andrewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, clicked too quickly and forgot to actually select "Approve".

nbrahms
nbrahms approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@nbrahms nbrahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably re-write the PR description. I believe this change is more about updating for the new permission-request data structure used by the P0 backend.

Other than that, just the tiniest of style feedback.

src/plugins/aws/ssh.ts Outdated Show resolved Hide resolved
@GGonryun GGonryun changed the title switch ssh permissions to lifecycle SDK Update existing SSH permission requests to match new backend data structures Nov 14, 2024
@GGonryun GGonryun merged commit 0b35f51 into main Nov 15, 2024
3 checks passed
@GGonryun GGonryun deleted the miguelcampos/eng-2988-cli-update-type-parameters-to-support-new-ssh-requests branch November 15, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0-andrewa p0-andrewa p0-andrewa approved these changes

@nbrahms nbrahms nbrahms approved these changes

@gergas3 gergas3 Awaiting requested review from gergas3

Assignees

@GGonryun GGonryun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GGonryun @nbrahms @p0-andrewa