Add lint + test #20
Merged
Add lint + test #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For code quality
To support easier testing and code co-location.
So far this is just basic testing for `p0 ls` and `p0 request`. This work identified a couple bugs that were remedied in this commit: - Improper sys.exit calls - Improper console.log (vs. console.error)
gergas3
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GitHub actions for validation
Add basic jest testing
So far this is just basic testing for
p0 lsandp0 request.REFACTOR: Move commands to their own file
To support easier testing and code co-location.
Add eslint
For code quality