ssh: Show friendly error message if not installed #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than showing the error message for `p0 request`.
GGonryun
approved these changes
Feb 22, 2024
| (i) => i.state === "installed" && i.type === "aws" | ||
| ); | ||
| if (!items?.length) { | ||
| throw "This organization is not configured for SSH access via the P0 CLI"; |
There was a problem hiding this comment.
Should we tell them how to remedy this issue in the error? 🤔
There was a problem hiding this comment.
It's a good question. There's no good way for the end user to remedy this directly. They could ask their P0 admin to install for SSH, but I'm not sure this is more helpful to tell them?
There was a problem hiding this comment.
Good point, Komal also raised a similar concern that not every user that runs into this error will be able to resolve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than showing the error message for
p0 request.