Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds GPL V3 license #32

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Adds GPL V3 license #32

merged 5 commits into from
Feb 23, 2024

Conversation

komal-dhull
Copy link
Contributor

@komal-dhull komal-dhull commented Feb 23, 2024

Adds GPLV3 license. Follows instructions provided by GNU here https://www.gnu.org/licenses/gpl-howto.en.html, which requires a COPYING file and a copyright and license notice included in each source code file. Additionally add an eslint plugin that verifies that the copyright notice is present and can be used to add the copyright notice by using --fix.

To review: all changes in src are just adding copyright.ts to the beginning of each file. COPYING.md is taken directly from https://www.gnu.org/licenses/gpl-3.0.md. Files to review are copyright.ts, package.json, and eslintrc.js

…//www.gnu.org/licenses/gpl-howto.en.html, which requires a COPYING file and a copyright and license notice included in each source code file. Additionally add an eslint plugin that verifies that the copyright notice is present and can be used to add the copyright notice by using --fix.
@@ -0,0 +1,675 @@
# GNU GENERAL PUBLIC LICENSE
Copy link
Contributor

@nbrahms nbrahms Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually this is in a file named LICENSE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, outside of the GNU licenses it's usually a LICENSE file. The GNU convention is to title it COPYING, and that's what the instructions for adding the GPL v3 licenses say. I looked into this a bit, found some discussion about COPYING vs LICENSE, it seems to not really matter beyond convention. Figured I'd go with the convention that the license documentation suggests 🤷

package.json Outdated Show resolved Hide resolved
copyright.ts Outdated Show resolved Hide resolved
@komal-dhull komal-dhull merged commit 7c1e747 into main Feb 23, 2024
2 checks passed
@komal-dhull komal-dhull deleted the komal/add-gplv3 branch February 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants