Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssm: Guide install of aws binaries #38

Merged
merged 3 commits into from
Feb 26, 2024
Merged

ssm: Guide install of aws binaries #38

merged 3 commits into from
Feb 26, 2024

Conversation

nbrahms
Copy link
Contributor

@nbrahms nbrahms commented Feb 25, 2024

ssm: Guide install of aws binaries

Make a user successful if they have not installed aws ssm.

Detects required aws binaries at ssh connection time. If these are missing,
prompt for installation.

Currently supports only MacOS ("darwin").

Also moves some SSM-specific code from the ssh command to the ssm plugin
file.

license: Fix whitespace error

Screenshot:

image

Make a user successful if they have not installed `aws ssm`.

Detects required aws binaries at ssh connection time. If these are missing,
prompt for installation.

Currently supports only MacOS ("darwin").

Also moves some SSM-specific code from the ssh command to the ssm plugin
file.
@nbrahms nbrahms self-assigned this Feb 25, 2024
Copy link
Contributor

@GGonryun GGonryun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good, left one question.

* the user declines, or if not a TTY, the installation commands are printed to
* stdout.
*/
export const ensureSsmInstall = async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we let the user know that we might require them to enter their sudo password? I sometimes this warning on other installers that may require elevated access.

@nbrahms nbrahms merged commit a6d78fa into main Feb 26, 2024
3 checks passed
@nbrahms nbrahms deleted the nathan/aws-cli-install branch February 26, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants