ls: Show keys and values #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only showed values. However, these are often not requested. Also show the value that should be requested.
nbrahms
force-pushed
the
nathan/ls-keys
branch
from
1605f16 to
52463b4
Compare
nbrahms
added a commit
that referenced
this pull request
Oct 31, 2024
I'd broken this in #42. Fix whitespace. Before: Showing the first 15 destinations (use `p0 ls ssh session destination <like>` to narrow results). Resources labeled with * are already accessible to you: After: Showing the first 15 destinations (use `p0 ls ssh session destination <like>` to narrow results). Resources labeled with * are already accessible to you:
nbrahms
added a commit
that referenced
this pull request
Oct 31, 2024
I'd broken this in #42. Fix whitespace. Before: ``` Showing the first 15 destinations (use `p0 ls ssh session destination <like>` to narrow results). Resources labeled with * are already accessible to you: ``` After: ``` Showing the first 15 destinations (use `p0 ls ssh session destination <like>` to narrow results). Resources labeled with * are already accessible to you: ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only showed values. However, these are often not requested. Also show the value that should be requested.
Requires https://github.com/p0-security/app/pull/1446
Screenshot: