Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: add example use cases #43

Merged
merged 4 commits into from
Feb 28, 2024
Merged

README: add example use cases #43

merged 4 commits into from
Feb 28, 2024

Conversation

komal-dhull
Copy link
Contributor

@komal-dhull komal-dhull commented Feb 27, 2024 •
edited
Loading

Addresses ENG-1647.

Also: change text referencing COPYING.md to LICENSE.md

nbrahms
nbrahms reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@nbrahms nbrahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the role assume doc

README.md Outdated Show resolved Hide resolved
@komal-dhull @nbrahms
Update README.md
a4f6a45 
Co-authored-by: Nathan Brahms <nbrahms@users.noreply.github.com>
nbrahms
nbrahms approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@nbrahms nbrahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@komal-dhull komal-dhull merged commit 94a2fce into main Feb 28, 2024
3 checks passed
@komal-dhull komal-dhull deleted the komal/readme-examples branch February 28, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbrahms nbrahms nbrahms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@komal-dhull @nbrahms