Skip to content

SSH: allow numbers to be used as arguments to ssh commands #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2024
Merged

SSH: allow numbers to be used as arguments to ssh commands #46

merged 2 commits into from
Feb 29, 2024

Conversation

GGonryun
Copy link
Contributor

@GGonryun GGonryun commented Feb 28, 2024 •
edited
Loading

This PR fixes a problem preventing users from using numbers as arguments e.g. p0 ssh private-node sleep 10

TypeError: argument.replace is not a function
    at /Users/miguelcampos/src/p0cli/dist/plugins/aws/ssm/index.js:119:18
    at Array.map (<anonymous>)
    at commandParameter (/Users/miguelcampos/src/p0cli/dist/plugins/aws/ssm/index.js:116:10)
    at /Users/miguelcampos/src/p0cli/dist/plugins/aws/ssm/index.js:141:18
    at Generator.next (<anonymous>)
    at fulfilled (/Users/miguelcampos/src/p0cli/dist/plugins/aws/ssm/index.js:5:58)

@GGonryun GGonryun requested a review from nbrahms February 28, 2024 22:47
@GGonryun GGonryun self-assigned this Feb 28, 2024
nbrahms
nbrahms approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@nbrahms nbrahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GGonryun GGonryun merged commit aafd7bb into main Feb 29, 2024
@GGonryun GGonryun deleted the miguelcampos/fix-number-ssh-args branch February 29, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbrahms nbrahms nbrahms approved these changes

Assignees

@GGonryun GGonryun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GGonryun @nbrahms