Users can start a session for nodes with a group approval #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGonryun
commented
Mar 26, 2024
| ok: true; | ||
| message: string; | ||
| id: string; | ||
| event: T; |
There was a problem hiding this comment.
The event payload has always been returned. We're just exposing it now via an interface.
GGonryun
commented
Mar 26, 2024
| if (!isPreexisting) print2("Waiting for access to be provisioned"); | ||
|
|
||
| const requestData = await waitForProvisioning<AwsSsh>(authn, id); | ||
| const requestWithId = { ...requestData, id }; | ||
| const requestWithId = { ...requestData, id, permission: event.permission }; |
There was a problem hiding this comment.
We rely on the returned permission object instead of waiting for the results of waitForProvisioning because SSH group requests workflow documents differ from SSH session request workflow documents.
If we use the permission value from the SSH group request document we won't have a real instance arn to ssh into.
GGonryun
changed the title
GGonryun
merged commit bab091a
into
miguelcampos/eng-1688-add-support-for-p0-request-ssh-group-group-id
3 checks passed
GGonryun
deleted the
miguelcampos/eng-1798-users-can-start-session-for-nodes-with-a-group-approval
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to connect to nodes that have been granted group approval.