gcp: Update for direct access-logging #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 2024 July 30, P0 updated GCP access-logging ingest to transition from a Pub/Sub-based ingest architecture, to a direct write from the organization's logging sink. Update the P0 TF provider to match this new model.
GGonryun
reviewed
Jul 31, 2024
| @@ -6,7 +6,7 @@ description: |- | |||
| An installation of P0, on a single Google Cloud project, for access-log collection, | |||
| which enhances IAM assessment. | |||
| To use this resource, you must also: | |||
| install the p0_gcp_iam_assessment resource,create a Pub/Sub topic,create a logging sink, publishing to this topic,grant your logging service account permissions to publish to this Pub/Sub topic, andgrant P0 the ability to subscribe to this Pub/Sub topic. | |||
| install the p0_gcp_iam_assessment resource, andgrant P0 the ability to create logging sinks in your project. | |||
There was a problem hiding this comment.
Suggested change
| install the p0_gcp_iam_assessment resource, andgrant P0 the ability to create logging sinks in your project. | |
| install the p0_gcp_iam_assessment resource, and grant P0 the ability to create logging sinks in your project. |
Oh wait, looks like this was autogenerated so it's probably not possible to fix
GGonryun
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 2024 July 30, P0 updated GCP access-logging ingest to transition from a Pub/Sub-based ingest architecture, to a direct write from the organization's logging sink.
Update the P0 TF provider to match this new model.