ENG-3380 Support currentVersion in p0_routing_rules #46
Conversation
Fix the p0_routing_rules resource so that it supports the currentVersion field required by the workflow POST API. Verified provider by creating and updating a number of basic routing rules.
I think they are useful to have for troubleshooting. They don't do anything unless debug logging is enabled. |
| if !current.Version.IsUnknown() && !current.Version.IsNull() { | ||
| currentVersion := current.Version.ValueString() | ||
| tflog.Debug(ctx, fmt.Sprintf("Current version: %s", currentVersion)) | ||
| currentVersionPtr = ¤tVersion |
There was a problem hiding this comment.
Doesn't this mean that if someone changes the version manually on the UI, the terraform state will be invalid? What happens if you delete your current Tf state and start from scratch?
There was a problem hiding this comment.
If the state is changed in the UI, it will work. Terraform does a read as part of the plan. It will show the differences and ask to apply them.
What this does is prevent Terraform from making changes if the state is concurrently modified after the plan is created.
If the TF state is deleted, it needs to be imported first. But that is existing behavior, not specific to this PR.
Fix the p0_routing_rules resource so that it supports the currentVersion field required by the workflow POST API.
Verified the provider by creating and updating a number of basic routing rules.