Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to bind to Ipv4 address #530

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Aug 25, 2023

Closes #533

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@adzialocha adzialocha marked this pull request as ready for review August 25, 2023 15:23
@adzialocha adzialocha marked this pull request as draft August 25, 2023 18:07
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 62.50% and no project coverage change.

Comparison is base (5fe70cc) 92.34% compared to head (2ca0746) 92.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         106      106           
  Lines       17850    17852    +2     
=======================================
+ Hits        16483    16485    +2     
  Misses       1367     1367           
Files Changed Coverage Δ
aquadoggo/src/network/service.rs 30.03% <50.00%> (ø)
aquadoggo/src/http/service.rs 96.87% <66.66%> (+0.03%) ⬆️
aquadoggo/src/config.rs 82.35% <100.00%> (+1.10%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzialocha adzialocha force-pushed the improve-network-config branch from b6cbdbd to b28eace Compare September 8, 2023 09:46
* main:
  Update version in Cargo.lock as well
  Do not panic when blob does not have all pieces yet (#563)
  Make cli version reflect the crate version
  One hash is enough when releasing binaries
  Remove unused methods from `EntryStore` (#560)
  Fix: dedup generated schema fields by key (#558)
@adzialocha
Copy link
Member Author

@sandreae Could you check this branch out and test if establishing connection between node works when you bind to the loopback interface (aka cargo run -- -i 127.0.0.1)? It doesn't work on my computer but I wonder if that's a configuration issue with my OS.

@sandreae
Copy link
Member

@sandreae Could you check this branch out and test if establishing connection between node works when you bind to the loopback interface (aka cargo run -- -i 127.0.0.1)? It doesn't work on my computer but I wonder if that's a configuration issue with my OS.

Same behaviour for me, local peers are discovered, but connection attempts timeout 🤔

@sandreae
Copy link
Member

Looks related: libp2p/rust-libp2p#4259

@sandreae
Copy link
Member

I just tested this and connection between nodes is successful:

cargo run -- -i 127.0.0.1

cargo run -- -i 0.0.0.0

@sandreae
Copy link
Member

Not sure exactly what that tells us 😅

@sandreae
Copy link
Member

I also updated to libp2p 0.5.3 but the behaviour didn't change as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change binding address in config
2 participants