Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger collection update in _onChange() #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guilhermeteodoro
Copy link

@guilhermeteodoro guilhermeteodoro commented Nov 25, 2016

Hi guys,

I found a bug on Backbone.VirtualCollection during a migration from Marionette 2 to Marionette 3.

I discovered a case where the collection update event should be triggered after a model change event if it doesn't pass through filter (this.accepts()) and already_here is true.

This is a partial fix, just for the 'remove case', but I think that maybe something similar should be done pass through filter (this.accepts()) too.

@guilhermeteodoro guilhermeteodoro changed the title _onChange should trigger update on remove trigger update in _onChange Nov 25, 2016
@guilhermeteodoro guilhermeteodoro changed the title trigger update in _onChange trigger collection update in _onChange() Nov 25, 2016
@guilhermeteodoro guilhermeteodoro changed the title trigger collection update in _onChange() Trigger collection update in _onChange() Nov 25, 2016
@p3drosola
Copy link
Owner

Hi @guilhermeteodoro sorry for the delay.

Do you think you can make an attempt at handling the other cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants