Trigger collection update in _onChange() #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I found a bug on
Backbone.VirtualCollection
during a migration from Marionette 2 to Marionette 3.I discovered a case where the collection
update
event should be triggered after a modelchange
event if it doesn't pass through filter (this.accepts()
) andalready_here
istrue
.This is a partial fix, just for the 'remove case', but I think that maybe something similar should be done pass through filter (
this.accepts()
) too.