Remove old vector workarounds, slightly modernize #5140
+12
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimír Štill <vladimir.still@altera.com>
Signed-off-by: Vladimír Štill <vladimir.still@altera.com>
Signed-off-by: Vladimír Štill <vladimir.still@altera.com>
vlstill
added
core
vlstill
commented
Feb 21, 2025
vlstill
changed the title
Signed-off-by: Vladimír Štill <vladimir.still@altera.com>
ChrisDodd
approved these changes
Feb 22, 2025
AdarshRawat1
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long overdue cleanup I noticed when working on #5133. Apparently these are workarounds for GCC 4.*, we are safe to remove them as we require GCC 9+. A small potential for breaking change due to the
GetImplnamespace being removed and thegetforIR::Vectormoving toP4::IRto facilitate ADL. If anyone calls thegetwith explicit namespace (or has explicitusingon it) they should just remove the namespaces and rely on argument-dependent lookup.When there, I also slightly modernized parts of the code & fixed some weirdness.