Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ptf-ebpf CI test to Ubuntu 22.04 #5159

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jafingerhut
Copy link
Contributor

No description provided.

Signed-off-by: Andy Fingerhut <andy.fingerhut@gmail.com>
@jafingerhut
Copy link
Contributor Author

I have seen that the PSATernaryTest fails when trying to run the ptf-ebpf CI test on Ubuntu 22.04. It passes fine on Ubuntu 20.04. I have done a little bit of debugging, enough to determine that the table entries added, and the packet sent in, are the same on Ubuntu 20.04 and 22.04 tests, but the packet out is different on 22.04, for reasons that I do not understand.

By 2025-Apr-01, we should choose among one of the following courses of action:
(a) disable this CI test
(b) modify the test so it passes on Ubuntu 22.04 (or 24.04)
(c) modify the test so it runs in Ubuntu 20.04 in a container or something similar.

(b) seems preferable, if we can figure out how.

@fruffy
Copy link
Collaborator

fruffy commented Mar 3, 2025

I have seen that the PSATernaryTest fails when trying to run the ptf-ebpf CI test on Ubuntu 22.04. It passes fine on Ubuntu 20.04. I have done a little bit of debugging, enough to determine that the table entries added, and the packet sent in, are the same on Ubuntu 20.04 and 22.04 tests, but the packet out is different on 22.04, for reasons that I do not understand.

By 2025-Apr-01, we should choose among one of the following courses of action: (a) disable this CI test (b) modify the test so it passes on Ubuntu 22.04 (or 24.04) (c) modify the test so it runs in Ubuntu 20.04 in a container or something similar.

(b) seems preferable, if we can figure out how.

Iirc there are two reasons: Different kernel version and different clang version. The combination causes the produce program to be rejected by the verifier. I can take a look at this.

@jafingerhut jafingerhut marked this pull request as draft March 5, 2025 16:16
@jafingerhut jafingerhut marked this pull request as ready for review March 17, 2025 11:35
@jafingerhut
Copy link
Contributor Author

@fruffy This PR is one possible way forward -- i.e. comment out the one test that fails on Ubuntu 22.04 in the EBPF back end, named PSATernaryTest, but keep all of the other passing ones uncommented. If you approve of merging this, I will create a p4c issue to track if/when someone fixes the PSATernaryTest on Ubuntu 22.04.

@fruffy
Copy link
Collaborator

fruffy commented Mar 17, 2025

@fruffy This PR is one possible way forward -- i.e. comment out the one test that fails on Ubuntu 22.04 in the EBPF back end, named PSATernaryTest, but keep all of the other passing ones uncommented. If you approve of merging this, I will create a p4c issue to track if/when someone fixes the PSATernaryTest on Ubuntu 22.04.

I have some changes ready which I would like to try out before disabling this test. But might take a little longer until I can create a PR.

@jafingerhut
Copy link
Contributor Author

@fruffy This PR is one possible way forward -- i.e. comment out the one test that fails on Ubuntu 22.04 in the EBPF back end, named PSATernaryTest, but keep all of the other passing ones uncommented. If you approve of merging this, I will create a p4c issue to track if/when someone fixes the PSATernaryTest on Ubuntu 22.04.

I have some changes ready which I would like to try out before disabling this test. But might take a little longer until I can create a PR.

Great. I will leave this PR open in case it turns out we want it by April 1, but also happy to close this one if a bug fix for the failing test case on Ubuntu 22.04 is implemented.

@fruffy
Copy link
Collaborator

fruffy commented Mar 18, 2025

@tatry Any idea why this test could fail? Related to the clang version?

@tatry
Copy link
Contributor

tatry commented Mar 19, 2025

@fruffy

Any idea why this test could fail? Related to the clang version?

I'm not sure, probably related to clang version. As far as I remember, some time ago I tried to install the same same kernel (at least version of kernel from repo) on both Ubuntu versions, 20.04 and 22.04 but different clang (10 vs 12). On older tests passed fine but on 22.04 some failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants