Introduce Editor Trait for Flexible Text Widget Integration and Feature Flag for CodeEditor #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces an abstraction layer via the
Editor
trait to enable users to incorporate additional text widgets with syntax highlighting. It also implements a feature flag for the existingCodeEditor
.Changes Made
Editor
trait with methodsappend
andsyntax
to generalize functionality for text widgets.highlight
and associated functions inhighlighting.rs
to accept genericEditor
trait bounds instead of directly referencingCodeEditor
.Editor
forCodeEditor
, definingappend
andsyntax
methods accordingly.Motivation and Context
The addition of the
Editor
trait allows for flexibility in integrating various text widgets with syntax highlighting capabilities, enhancing the extensibility and usability of the codebase. The feature flag ensures compatibility with existing code while paving the way for future enhancements.Notes for Reviewers
Please review the changes to
highlighting.rs
andlib.rs
for adherence to the newEditor
trait usage and feature flag implementation. Ensure compatibility with existing features and provide feedback on the design and implementation decisions.