Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix client project test #12

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix client project test #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
043fcbc
Restrict peer dependencies to `eslint@^8` and `eslint-plugin-n@^16`
danyalaytekin Apr 10, 2024
09841cc
Bump devdep `eslint-plugin-n` to `^16.6.2` from `^16.3.0`
danyalaytekin Apr 10, 2024
fae1bf3
Fix `eslint` to `~8.52` rather than `^8.51` - can't minor drift furth…
danyalaytekin Apr 10, 2024
2492ba3
Test client project using `eslint@8` and allow fetch
danyalaytekin Apr 10, 2024
02f2909
After remembering the existence of ESLint 9's flat config converter, …
danyalaytekin Apr 10, 2024
8c78696
Explain why `package.devDependencies.eslint` is `~8.52`
danyalaytekin Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ jobs:
run: |
npm install --save-dev ../packed/*.tgz

- name: Use shareable config (also checks peer dependencies)
- name: Use shareable config (also checks peer dependencies, not including eslint)
working-directory: ${{ runner.temp }}/some-project
run: |
echo '{ "extends": "pa11y" }' > .eslintrc.json
npx --no eslint .
npx eslint@8 .
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ Please check that everything works by running the following before opening a <ab
npm test
```

> [!NOTE]
> `npm test` also enforces the absence of rules deprecated by ESLint. At present this project's rules are considered fresh by `8.52.0`, but several are marked as deprecated by `8.53.0` and above. For this reason, `package.devDependencies.eslint` should not be allowed to progress further than `8.52.0` until the ruleset is upgraded. A client project that does not enforce the absence of deprecated rules may use a higher version of ESLint.

### Testing the GitHub Actions workflows

This project's GitHub Actions workflows can be tested locally using [nektos/act](https://github.com/nektos/act), which can be installed with Homebrew:
Expand Down
Loading
Loading