fix crash when node flags updated after delete node #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatatupi
approved these changes
Dec 9, 2025
Collaborator
There was a problem hiding this comment.
Great fix.
The previous connection was not connecting to a receiver, only to a lambda. So if the node was deleted, the lambda would still be valid and cause a crash.
With the fix, when the object is destroyed, Qt automatically disconnects the slot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
fix crash when node flags updated after delete node, lambda capture
thisbut no contextthisso Qt signals will not auto disconnect,setLockedStateis use after free