Update GitHub generated Download URL for maximum compatibility #157

Signed-off-by: tdruez <tdruez@nexb.com>
package-url · Jul 4, 2024 · aa217f1 · aa217f1
1 parent b744d07
commit aa217f1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -4,6 +4,12 @@ Changelog
 0.16.0 (unreleased)
 -------------------
 
+0.15.2 (2024-07-04)
+-------------------
+
+- Update GitHub generated Download URL for maximum compatibility.
+  https://github.com/package-url/packageurl-python/issues/157
+
 0.15.1 (2024-06-13)
 -------------------
 

diff --git a/setup.cfg b/setup.cfg
@@ -1,6 +1,6 @@
 [metadata]
 name = packageurl-python
-version = 0.15.1
+version = 0.15.2
 license = MIT
 description = A purl aka. Package URL parser and builder
 long_description = file:README.rst

diff --git a/src/packageurl/contrib/purl2url.py b/src/packageurl/contrib/purl2url.py
@@ -40,7 +40,7 @@ def get_repo_download_url_by_package_type(
         raise ValueError("Only zip and tar.gz extensions are supported")
 
     download_url_by_type = {
-        "github": f"https://github.com/{namespace}/{name}/archive/refs/tags/{version}.{archive_extension}",
+        "github": f"https://github.com/{namespace}/{name}/archive/{version}.{archive_extension}",
         "bitbucket": f"https://bitbucket.org/{namespace}/{name}/get/{version}.{archive_extension}",
         "gitlab": f"https://gitlab.com/{namespace}/{name}/-/archive/{version}/{name}-{version}.{archive_extension}",
     }

diff --git a/tests/contrib/test_purl2url.py b/tests/contrib/test_purl2url.py
@@ -78,7 +78,8 @@ def test_purl2url_get_download_url():
         "pkg:npm/is-npm@1.0.0": "http://registry.npmjs.org/is-npm/-/is-npm-1.0.0.tgz",
         "pkg:hackage/cli-extras@0.2.0.0": "https://hackage.haskell.org/package/cli-extras-0.2.0.0/cli-extras-0.2.0.0.tar.gz",
         "pkg:nuget/System.Text.Json@6.0.6": "https://www.nuget.org/api/v2/package/System.Text.Json/6.0.6",
-        "pkg:github/nexb/scancode-toolkit@3.1.1?version_prefix=v": "https://github.com/nexb/scancode-toolkit/archive/refs/tags/v3.1.1.tar.gz",
+        "pkg:github/nexb/scancode-toolkit@3.1.1?version_prefix=v": "https://github.com/nexb/scancode-toolkit/archive/v3.1.1.tar.gz",
+        "pkg:github/StonyShi/reactor-netty-jersey@ac525d91ff1724395640531df08e3e4eabef207d": "https://github.com/stonyshi/reactor-netty-jersey/archive/ac525d91ff1724395640531df08e3e4eabef207d.tar.gz",
         "pkg:bitbucket/robeden/trove@3.0.3": "https://bitbucket.org/robeden/trove/get/3.0.3.tar.gz",
         "pkg:bitbucket/robeden/trove@3.0.3?version_prefix=v": "https://bitbucket.org/robeden/trove/get/v3.0.3.tar.gz",
         "pkg:gitlab/tg1999/firebase@1a122122": "https://gitlab.com/tg1999/firebase/-/archive/1a122122/firebase-1a122122.tar.gz",