Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ffi - load full ffi namespace, initial ffi verifier #357

Closed
wants to merge 104 commits into from
Closed

Feat/ffi - load full ffi namespace, initial ffi verifier #357

wants to merge 104 commits into from

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jul 8, 2023 •
edited
Loading

Following on from the awesome work from @elliottmurray and @mikegeeves

Will document properly over the next couple of days, (probably next week)

  • as part of the ffi maintainers guide
  • pulling out other sources of pact verifications (both ruby, rust and jvm backed) so they can be referenced by others
  • work out where any discrepancies lie
  • where any logic is shared across client libraries and can be moved into the core
  • quality of life improvements to any ffi methods to aid maintainers/library creators

Work done so far

  • Loading of shared binaries for the following platform
OS Architecture
OSX x86_64
Linux x86_64
OSX arm64
Linux arm64
Windows x86_64

TODO

  • Message metadata content-type currently hard coded to application/json
  • Plugin tests when they fail, dont appear to return the failures or successes to the log buffer
  • Log level gets globally applied, and isn't able to be changed, which interferes with the unit tests, and probably external tests within the same process. I think this is due to pact-reference using a global logging tracer.
  • write migration guide
  • bump to alpha version

elliottmurray and others added 30 commits July 17, 2021 13:26
@elliottmurray
feat: added rust linux/osx support
4fdabdd
@elliottmurray
feat: fix to pytest request signature@
2d7f943
@elliottmurray
feat: first ffi interface
488d55f
@elliottmurray
feat: added so file
cf77d09
@elliottmurray
fix: so now a relative path so picked up by tests (temp fix) Also som…
f914c50 
…e changes to docker37 which I will need to do to all
@elliottmurray
chore: move dyn libs to libs folder@
cd85969
@elliottmurray
feat: some work on preparing verify call
2b67e39
@elliottmurray
feat: refactoring to prepare verify
60ac756
@elliottmurray
feat: added rust linux/osx support
34f67a7
@elliottmurray
feat: fix to pytest request signature@
afd0931
@elliottmurray
feat: first ffi interface
6c95248
@elliottmurray
feat: added so file
de93a1f
@elliottmurray
fix: so now a relative path so picked up by tests (temp fix) Also som…
be6c971 
…e changes to docker37 which I will need to do to all
@elliottmurray
chore: move dyn libs to libs folder@
4b239e4
@elliottmurray
feat: some work on preparing verify call
e7d686a
@elliottmurray
feat: refactoring to prepare verify
050ee0e
@mikegeeves
docs(readme): trivial 'hello world' changes :)
7d18a2f
@mikegeeves
docs(readme): update python versions mentioned to those supported (go…
214c47d 
…ing by the tox list)
@mikegeeves
build(flake8): exclude venv and tox dirs from flake8 linting
a84f856
@mikegeeves
build(ffi): use libs from pact dir instead of libs. Bump to 0.0.1. Mi…
2d30706 
…nor doc tidy
@mikegeeves
feat(ffi verifier): very basic call of verify, with no args
c6ded0a
@mikegeeves
feat(ffi verifier): verifier test, looking at log output
e9c1bb0 
The return code is straightforward, but having problems with the logging. When setting up the FFI
objects etc, it doesn't seem to work unless it's a basically a singleton, it seems hard to split up.
I don't like it but going with this for now :)
@mikegeeves
feat(ffi verifier): verifier test, looking at log output
358748f
@mikegeeves
feat(ffi verifier): set log level for output
070f905
@mikegeeves
feat(ffi verifier): help and version tests
cf0bfee
@mikegeeves
feat(ffi verifier cli): use FFI to determine the args for the CLI wra…
3471c12 
…pper
@mikegeeves
feat(ffi verifier): add possible values e.g. to loglevel
11228ed
@mikegeeves
feat(ffi verify): add in default value
69233a6
@mikegeeves
feat(ffi verifier cli): handle both flags and options, along with mul…
3486281 
…tiple
@mikegeeves
feat(ffi verifier cli): construct args string from inputs. Call pactf…
283dcef 
…fi_free_string to cleanup
@YOU54F YOU54F linked an issue Jul 11, 2023 that may be closed by this pull request
Installer #242
Closed
This was referenced Jul 11, 2023
Closed
Closed
@YOU54F YOU54F linked an issue Jul 11, 2023 that may be closed by this pull request
Implement FFI interface for Provider #243
Closed
YOU54F added 13 commits July 26, 2023 16:04
@YOU54F
chore: move PACT_FFI_PATH to constants
0811665
@YOU54F
chore: update release script to support beta release tag formats
e492da6
@YOU54F
feat(examples): showcase FFIVerify for HTTP
f7b75ea
@YOU54F
feat: MessageProvider Verifier with FFIVerify plus examples
f1cea52 
    TODO
    - Message Metadata Content-Type hardcoded to application/json
    - Allow switching between rust/ruby core whilst in beta

    Notes
    - Message HTTP proxy needs  to drop `contents`
@YOU54F
Merge remote-tracking branch 'origin/master' into feat/ffi
5dea5dc
@YOU54F
feat: MessageProvider now returns VerifyResult(return_code, logs)
e5d46e9
@YOU54F
chore: avoid full path when checking for error message in test
c867226
@YOU54F
chore(test): add PACT_DO_NOT_TRACK
6916758
@YOU54F
chore(test): add PACT_DO_NOT_TRACK
6e69633
@YOU54F
chore(test): windows has diff error for file not found
8c07bc3
@YOU54F
chore!: drop ci testing of python 3.6 - fails in cirrus
28776c2 
most likely due to container, see workaround in GHA
@YOU54F
test: showcase grpc v4 pact verification
703bac6 
use area calculator proto example matching up
with other pact grpc examples. Pact is precreated
and not currently generated from pact-python
@YOU54F
ci(gha): test windows with plugins only
11ed3c2
@YOU54F
Copy link
Member Author

YOU54F commented Jul 26, 2023 •
edited
Loading

Not sure why Snyk is complaining, I can't see the detail behind the check without logging into snyk, and my gh user doesn't have access.

Should it be reporting back to the PR as a comment?

🤔

@YOU54F YOU54F linked an issue Jul 26, 2023 that may be closed by this pull request
Drop support for Python < 3.7 #350
Closed
@YOU54F YOU54F mentioned this pull request Jul 27, 2023
Closed
@YOU54F
Copy link
Member Author

YOU54F commented Aug 2, 2023

superseded by #367

@YOU54F YOU54F closed this Aug 2, 2023
@JP-Ellis JP-Ellis mentioned this pull request Sep 27, 2023
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python < 3.7 Implement FFI interface for Provider Installer
3 participants
@YOU54F @elliottmurray @mikegeeves