Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): don't pin dev dependencies #12

Closed
wants to merge 1 commit into from
Closed

Conversation

JP-Ellis
Copy link
Contributor

No description provided.

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis requested a review from vwong February 12, 2025 22:59
@JP-Ellis JP-Ellis self-assigned this Feb 12, 2025
@JP-Ellis
Copy link
Contributor Author

I noticed that the Renovate config was invalid, looking at the changes you made, I suspect that's what you intended @vwong?

@JP-Ellis
Copy link
Contributor Author

For more context, the best-practices config is defined here and it includes a pinDevDependencies preset.

@vwong
Copy link
Collaborator

vwong commented Feb 12, 2025

I find that with npm libraries, which this is, many leave dependencies unpinned - it makes it easier to upgrade on the consumer side. Hence I didn't want pinned versions.

@JP-Ellis
Copy link
Contributor Author

I find that with npm libraries[..], many leave dependencies unpinned - it makes it easier to upgrade on the consumer side.

If I'm understanding correctly, this applies to runtime dependencies only? If so, Renovate does behave like you're intending already and leaves SemVer ranges mostly intact. What's included in Renovate's best-practices configuration is the pinning of dev dependencies, as these should not impact consumer-side installations, and they ensure a reproducible developer experience.

Renovate's PR to pin dependencies:

Is only pinning dev dependencies, and is not changing ranges for any of the runtime dependencies. Is that still what you want? Or do you want to use semver ranges for dev dependencies as well?

@vwong
Copy link
Collaborator

vwong commented Feb 13, 2025

Ok, in that case. unpinned prod, pinned dev is fine by me.

@JP-Ellis
Copy link
Contributor Author

All good, I'll close this PR and revert the commit that's bugging Renovate 👍

@JP-Ellis JP-Ellis closed this Feb 13, 2025
@JP-Ellis JP-Ellis deleted the chore/no-pin-dev-deps branch February 13, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants