Skip to content

Commit

Permalink
cleaning
Browse files Browse the repository at this point in the history
  • Loading branch information
oscar-guerin committed Nov 5, 2024
1 parent a1bc980 commit b17c5f5
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 30 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ngx-repository-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
run: npm ci

- name: Test
run: npm run testt:ci
run: npm run test:ci

- name: Archive coverage artifact
if: github.ref == 'refs/heads/master'
Expand All @@ -60,7 +60,7 @@ jobs:

coverall:
name: Coverall
needs: [testt, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository]
needs: [ test, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
if: github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:
deploy-ngx-repository:
name: Deploy ngx-repository
runs-on: ubuntu-latest
needs: [ testt, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
needs: [ test, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
if: github.ref == 'refs/heads/master'
strategy:
matrix:
Expand Down Expand Up @@ -209,7 +209,7 @@ jobs:
deploy-witty-ngx-repository:
name: Deploy witty ngx-repository
runs-on: ubuntu-latest
needs: [ testt, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
needs: [ test, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
if: github.ref == 'refs/heads/master'
strategy:
matrix:
Expand Down Expand Up @@ -245,7 +245,7 @@ jobs:
deploy-ngx-http-repository:
name: Deploy ngx-http-repository
runs-on: ubuntu-latest
needs: [ testt, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
needs: [ test, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
if: github.ref == 'refs/heads/master'
strategy:
matrix:
Expand Down Expand Up @@ -275,7 +275,7 @@ jobs:
deploy-witty-ngx-http-repository:
name: Deploy witty ngx-http-repository
runs-on: ubuntu-latest
needs: [ testt, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
needs: [ test, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
if: github.ref == 'refs/heads/master'
strategy:
matrix:
Expand Down Expand Up @@ -311,7 +311,7 @@ jobs:
deploy-ngx-firestore-repository:
name: Deploy ngx-firestore-repository
runs-on: ubuntu-latest
needs: [ testt, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
needs: [ test, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
if: github.ref == 'refs/heads/master'
strategy:
matrix:
Expand Down Expand Up @@ -341,7 +341,7 @@ jobs:
deploy-witty-ngx-firestore-repository:
name: Deploy witty ngx-firestore-repository
runs-on: ubuntu-latest
needs: [ testt, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
needs: [ test, lint, build-ngx-repository, build-ngx-http-repository, build-ngx-firestore-repository ]
if: github.ref == 'refs/heads/master'
strategy:
matrix:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,7 @@ After dependency installation, you can run others commands :

````shell script
# Run the tests
npm run testt
npm run test

# Run the linter
npm run lint
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { EMPTY, Observable, of, OperatorFunction } from 'rxjs';
import { expand, first, map, switchMap, toArray } from 'rxjs/operators';
import { Page } from '../core/model/page';
import flatten from '../../../../utils/src/flatten';
import {EMPTY, Observable, of, OperatorFunction} from 'rxjs';
import {expand, first, map, switchMap, toArray} from 'rxjs/operators';
import {Page} from '../core/model/page';
import {flatten} from "../../../../utils/src/flatten";

Check failure on line 4 in projects/ngx-repository/src/lib/operator/fetch-all-page.operator.ts

View workflow job for this annotation

GitHub Actions / Lint (18)

Strings must use singlequote

Check failure on line 4 in projects/ngx-repository/src/lib/operator/fetch-all-page.operator.ts

View workflow job for this annotation

GitHub Actions / Lint (18)

Strings must use singlequote

export function fetchAllPage<T>(fetch: (page: number) => Observable<Page>): OperatorFunction<Page<T>, T[]> {
return (source: Observable<Page<T>>): Observable<T[]> => {
Expand Down
3 changes: 0 additions & 3 deletions projects/ngx-repository/src/public-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,6 @@ export * from './lib/core/response/processor/id-response.processor';
export * from './lib/core/response/processor/void-response.processor';
export * from './lib/core/response/processor/response.processor';

//todo export laissé ici
export { getIdFromObject } from './lib/core/common/functions';

export { AfterDenormalizeEvent } from './lib/normalizer/event/after-denormalize.event';
export { BeforeDenormalizeEvent } from './lib/normalizer/event/before-denormalize.event';
export { AfterNormalizeEvent } from './lib/normalizer/event/after-normalize.event';
Expand Down
4 changes: 2 additions & 2 deletions projects/ngx-repository/src/testing/mock.model.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Column } from '../lib/core/decorator/column.decorator';
import {Column} from '../lib/core/decorator/column.decorator';

export class Mock {

Expand All @@ -7,7 +7,7 @@ export class Mock {
public mySecondProperty: string;

@Column({field: 'name', writeOnly: true})
public name: string = 'testt';
public name: string = 'test';

public constructor(data?: Partial<Mock>) {
if (data) {
Expand Down
15 changes: 6 additions & 9 deletions projects/ngx-repository/tsconfig.lib.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"outDir": "../../dist/out-tsc/lib",
"outDir": "../../out-tsc/lib",
"declarationMap": true,
"declaration": true,
"inlineSources": true,
"types": ["node", "jasmine"],
"lib": [
"dom",
"es2018"
],
"rootDirs": ["src", "../utils/src"]
]
},
"angularCompilerOptions": {
"skipTemplateCodegen": true,
Expand All @@ -19,13 +18,11 @@
"strictInjectionParameters": true,
"enableResourceInlining": true
},
// "include": [
// "src/**/*.ts",
// "../utils/src/*.ts"
// ],
"include": [
"src/**/*.ts"
],
"exclude": [
"src/test.ts",
"**/*.spec.ts",
// "../utils/src/*.spec.ts"
"**/*.spec.ts"
]
}
4 changes: 1 addition & 3 deletions projects/utils/src/flatten.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
const flatten = (array: any[]) => array.reduce((acc, val) => acc.concat(val), []);

export default flatten;
export const flatten = (array: any[]) => array.reduce((acc, val) => acc.concat(val), []);

0 comments on commit b17c5f5

Please sign in to comment.