Refactoring in showing cycle option value in cart #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mateus-picoloto
commented
Jul 28, 2023
mateus-picoloto
commented
| Questions | Answers |
|---|---|
| Issue | https://mundipagg.atlassian.net/browse/PAOPN-460 |
| What? | Refactoring in showing cycle option value in cart. |
| Why? | To not override an magento core template. |
| How? | Removing template override and changing option cycle value via plugin |
Gandalf - Continuous AppSec📌 LembreteEste repositório está sendo monitorando de forma automática e contínua em busca de achados que possam comprometer a segurança da aplicação. 📋 Resumo de achados no repositório magento2
|
mateus-picoloto
requested review from
mauriciohaygert,
RafaMelazzo and
fabiano-mallmann
RafaMelazzo
reviewed
Jul 31, 2023
RafaMelazzo
approved these changes
Jul 31, 2023
fabiano-mallmann
approved these changes
Aug 1, 2023
|
Kudos, SonarCloud Quality Gate passed! |
fabiano-mallmann
approved these changes
Aug 1, 2023
mateus-picoloto
added a commit
that referenced
this pull request
Oct 4, 2023
* refactoring Invoice block and template * removing target attribute * fixing names and translations * adding NumberFormatHelper * refactoring BilletCreditCard block and template * removing line break elements and changing to use paragraph elements * changing to return type be in comment section * changing to return type be in comment section * Refactoring creditCard.phtml template * Refactoring creditCard.phtml template * Refactoring creditCard.phtml template * Refactoring creditCard.phtml template * refactoring order_charge block and template * removing unnecessary return statement * changing space location in html generator * Refactoring twoCreditCard info class and phtml * refactoring pix block and template * removing unnecessary parameter passage * injecting PixHelper via di * fixing text and adding space between use statements and class declaration * refactor: Refactoring billet info class and phtml * refactor: pix in the admin and customer view (#212) * refactor: html elements be in template in order_charge and invoice blocks (#210) * refactor: removing unused priceFinal template (#211) * compatibilization with magento 2.4.6 and PHP 8.2 * Revert "compatibilization with magento 2.4.6 and PHP 8.2" This reverts commit 86f779e. * feat: compatibilization with magento 2.4.6 and PHP 8.2 (#214) * refactor: showing cycle option value in cart (#213) * Feat: Clear checkout error messages on field change (#216) * Feat: Clear checkout error messages on field change * Changed var to const * Defined constants instead of duplicating literals * ⬆️ Bump word-wrap from 1.2.3 to 1.2.5 in /e2e (#218) * feat: compatibilization with bundle js (#217) * improve: add recurence items in catalog menu (#219) * improve: add day cycle in recurring product (#220) * cd: add new images to cd (#215) * Fix: Added translations admin menu items (#222) * Fix: Removed domain protocol from csp_whitellist.xml (#223) * Refactor: Improve observers code (#224) * Improve observers code * Removinh unnecessary else * refactor: new function to remove if * added function to remove if * Fix: translations (#225) * cd: add marketplace on images * cd: fix test image * cd: add composer allow root * feat: removing string extraction from recurrence (#226) * feat: added pix informations to graphql (#227) * Added pix informations to graphql * Remove the unused function parameter "$subject" * fix: adding subject parameter in plugin --------- Co-authored-by: Mateus Picoloto <mateus.picoloto@pagar.me> * refactor: moving inline css to css file (#230) * build: changing module core version (#231) * build: changing module core version (#232) * build: changing module core version * build: changing minimum stability * fix: set area code only if is not setted (#233) * cd: refactory cd (#235) * refactor: admin creditCard block and template (#236) * fix: changing to use emulateAreaCode (#238) * feat: adding enabled recurrence config validation to recurrences features * Revert "feat: adding enabled recurrence config validation to recurrences features" This reverts commit dc6e3a2. * Fix Webapi\Exception __construct arguments * feat: adding enabled recurrence config validation to recurrences features (#239) * fix: adding pagarmeConfig property (#241) * fix: error wih default brand or null (#244) * fix: add conditional when wallet fields don't exist (#243) * PAOPN-576: add shipping and taxs in subs (#242 ) * fix: brand validation call (#245) * feat: changing cycles to discount in subscriptions and plans (#246) * fix: recurrence price mask showing NaN for all values (#248) * fix: changing to use messageList from magento (#249) * fix: strlen on null value for php 8.2 (#250) * fix: release number version (#251) * Release/2.2.5 (#252) * feat: adding subscriptions to sales menu and re-adding enabled gateway dependency to show recurrence settings (#253) * fix: change to only update installments for valid brands (#255) * fix: receive only magento webhooks (#254) * fix: adding due_at, bank and instructions information to be send to createOrder for billet payment method (#256) * Revert "fix: adding due_at, bank and instructions information to be send to createOrder for billet payment method" (#257) This reverts commit abf9308. * build: changing module core version (#258) --------- Co-authored-by: RafaMelazzo <rafael.melazzo@stone.com.br> Co-authored-by: Fabiano Mallmann <25328512+fabiano-mallmann@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: robsoned <robsoneduardosantos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.