Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Webapi\Exception __construct arguments #240

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

robsoned
Copy link
Contributor

Questions Answers
Issue #237
What? Updated the httpCode argument when throwing a new Magento\Framework\Webapi\Exception.
Why? Magento\Framework\Webapi\Exception constructor throws an Exception if httpCode is not between 400 and 599
How? Passing a httpCode, expected from Webapi\Exception, instead of 0, or any other number that comes from a caught exception. } catch (\Exception $e) { for example, does not guarantee that $e->getCode() is going to return a number between 400 and 599.

📦 Attachments (if appropriate)

Magento\Framework\Webapi\Exception constructor

image

💬 Important guidelines

@backstage-catalog-validator
Copy link

🚀 Este repositório ainda não está catalogado no Backstage.

Por favor, catalogue-o seguindo as instruções nesta documentação. [Via VPN].

Se você tiver alguma dúvida, sinta-se à vontade para entrar em contato conosco no canal do Slack #backstage.

@devsec-app-pagarme
Copy link

Gandalf - Continuous AppSec

📌 Lembrete

Este repositório está sendo monitorando de forma automática e contínua em busca de achados que possam comprometer a segurança da aplicação.
Para maiores detalhes, acesse aqui à plataforma.

📋 Resumo de achados no repositório magento2

Criticade Achados
Critical 0
High 6
Medium 0
Low 0

@RafaMelazzo RafaMelazzo merged commit f957a24 into pagarme:stg Aug 31, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants