completed CMM activity#70
Open
lmieu wants to merge 2 commits intopaircolumbus:masterfrom
lmieu:lmusie
Open
Conversation
mikegee
reviewed
Jan 15, 2017
anagram_detector.rb
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Implement this in such a way that when called below, detect_anagram will result in true or false. | |||
| def canonical(word) | |||
| word.downcase! | |||
Member
There was a problem hiding this comment.
Modifying the input is typically unexpected.
puts "What word do you want to check?"
word = gets.chomp
canonical_version_of_word = canonical(word)
puts "The canonical version of #{word} is #{canonical_version_of_word}."What word do you want to check?
ALLCAPSWORD
The canonical version of allcapsword is ["a", "a", "c", "d", "l", "l", "o", "p", "r", "s", "w"].
mikegee
reviewed
Jan 23, 2017
| # Implement this in such a way that when called below, detect_anagram will result in true or false. | ||
| def canonical(word) | ||
| down = word.downcase | ||
| canon = down.split("").sort_by{|char| char} |
Member
There was a problem hiding this comment.
The String#chars method is a bit clearer than split("").
Member
There was a problem hiding this comment.
.sort_by{|char| char} is equivalent to just .sort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaybobo