Correct and extendible form in coffeescript#26
Open
jonahroth wants to merge 2 commits intopaircolumbus:masterfrom
Open
Correct and extendible form in coffeescript#26jonahroth wants to merge 2 commits intopaircolumbus:masterfrom
jonahroth wants to merge 2 commits intopaircolumbus:masterfrom
Conversation
|
This works, great job. A way to improve it would be to edit the requirements live while the user types in the control fields. Also to add a 'disabled' attribute to the submit button until all requirements are satisfied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kmodlich @maxdignan
Spent some time trying to refactor this code so that additional requirements could be added if necessary (and learning how coffeescript works)