Skip to content

all done #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schoetlr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

all done #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions letsdrill.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,23 @@
def get_letter_grade(integer)

#Put your code here!

if (90..100).include?(integer)
Copy link

@djlax805 djlax805 May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting solution to use a range and include?! You could also use Ruby's comparable methods since they are integers.

"A"
elsif (80..89).include?(integer)
"B"
elsif (70..79).include?(integer)
"C"
elsif (60..69).include?(integer)
"D"
else
"F"
end
end

def shortest_string(array)

#Put your code here!
return nil if array.empty?
Copy link

@djlax805 djlax805 May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this line is necessary as min_by will return nil by default if the array is empty. Nice use of the & method syntax though 😄


array.min_by(&:length)

end

Expand Down