Conversation
mikegee
reviewed
Nov 29, 2019
| end | ||
| } | ||
| # Implicit return! Because we can! | ||
| shortest |
Member
There was a problem hiding this comment.
This is very easy to read. 👍
Ruby provides many methods to built-in classes. In particular, all these methods on Enumerable are available to instances of Array.
Consider rewriting this method to sort the input array by the length of the elements, then just plucking off the answer.
Or, if you scan through those Enumerable methods, you might find min_by which basically does the whole thing for you. But what's the fun in that?
Author
There was a problem hiding this comment.
Thanks very much for the feedback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used a ternary for the letter grade function, and I was going to try to do something fancy with Array.map for the other function, but I ended up doing a regular Array.each loop.