Eric Chen fixed letsdrill.rb to execute as intended#122
Open
chenthehero wants to merge 1 commit intopaircolumbus:masterfrom
Open
Eric Chen fixed letsdrill.rb to execute as intended#122chenthehero wants to merge 1 commit intopaircolumbus:masterfrom
chenthehero wants to merge 1 commit intopaircolumbus:masterfrom
Conversation
djlax805
reviewed
Jun 5, 2020
|
|
||
| end | ||
| if integer >= 90 | ||
| return "A" |
There was a problem hiding this comment.
Awesome stuff, few quick things.
-
In Ruby you do not need an explicit
returnit will return the last evaluated line of code in the block. -
Sometimes conditionals can grow pretty quick and get ugly, what would be your next steps to refactor this logic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.