Open
Conversation
added 2 commits
January 19, 2018 09:26
mikegee
reviewed
Jan 20, 2018
lib/deaf_grandma.rb
Outdated
| loop do | ||
| user_input = get_user_input | ||
| p speak(user_input) | ||
| break if @bye_counter == 3 |
Member
There was a problem hiding this comment.
Since @bye_counter is compared with 3 in two places, consider extracting a method to combine the duplication. In an actual application, this sort of duplication might lead to a bug when one is not kept in sync with the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaybobo