Complete RSpec coding challenges.#90
Open
LeslieKornes wants to merge 2 commits intopaircolumbus:masterfrom
Open
Complete RSpec coding challenges.#90LeslieKornes wants to merge 2 commits intopaircolumbus:masterfrom
LeslieKornes wants to merge 2 commits intopaircolumbus:masterfrom
Conversation
jaybobo
reviewed
May 11, 2018
Member
jaybobo
left a comment
jaybobo
left a comment
There was a problem hiding this comment.
How might you rewrite this your Deaf Grandma code more readable?
If you change the order of your conditions in your SuperFizzBuzz would it help you refactor your code a bit?
Also would you mind adding RSpec tests. I've added a few things to the README that should help. See the Instructions and Resources at the bottom of the page.
Author
|
@jaybobo Hopefully this is better :^| |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaybobo i don't love my fizzbuzz solution, but i had a nice chat with granny. i left the final line of deaf_grandma uncommented to run the program.