Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated arguments #256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated arguments #256

wants to merge 1 commit into from

Conversation

anthonydahanne
Copy link
Member

@anthonydahanne anthonydahanne commented May 5, 2023 •
edited
Loading

BP_BOOT_NATIVE_IMAGE_BUILD_ARGUMENTS and BP_BOOT_NATIVE_IMAGE

They've been deprecated for 2 years now

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner May 5, 2023 19:33
@anthonydahanne anthonydahanne added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels May 5, 2023
@anthonydahanne anthonydahanne mentioned this pull request May 5, 2023
Merged
5 tasks
@dmikusa
Copy link
Contributor

dmikusa commented May 8, 2023

I think this looks good.

@pivotal-david-osullivan I wanted to confirm with you on this? Major or minor change? I think technically we're supposed to use major with removals, but this has also been deprecated for 2 years. We could stick with major and just hold this until we're ready for another major release? It's not urgent to merge this.

Thoughts?

@pivotal-david-osullivan
Copy link
Contributor

I think that we should stick to convention and go with major, especially given it's not urgent to get it merged. So yes, once we have enough for a new major we can pull this in 👍

@dmikusa dmikusa added semver:major A change requiring a major version bump and removed semver:minor A change requiring a minor version bump labels May 17, 2023
@anthonydahanne
Remove deprecated arguments BP_BOOT_NATIVE_IMAGE_BUILD_ARGUMENTS and …
a92afd5 
…BP_BOOT_NATIVE_IMAGE

They've been deprecated for 2 years now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotal-david-osullivan pivotal-david-osullivan pivotal-david-osullivan approved these changes

Assignees
No one assigned
Labels
semver:major A change requiring a major version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthonydahanne @dmikusa @pivotal-david-osullivan