-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to ignore csv fields as requested in #15 #30
Conversation
Thanks for this patch. I'll take a look when I find a minute. Out of curiosity, what is your use case for this feature? |
First let me say that I really like the project and like supporting it with Use case: I have a system where data providers send us large data sets that I also have some thoughts on how to tackle issue #26 ( Best, On Mon, Oct 10, 2016 at 9:12 PM, Ben Welsh notifications@github.com wrote:
|
The `copy_template` logic was used for both standard and overloaded mapping fields. Refactor the code into it's own method.
Moments ago I pushed a change to the Rather than add a new keyword argument that requires users to explicitly list the headers they'd like to skip, I've tried to rework the application so it will "just work" and allow for headers to be omitted from the map input without any extra configuration. I've added the tests you submitted here to see if I got it right, and they appear to be passing. If you have the time, let me know what you think of this stab at a solution. |
@ckirby, if you don't protest, I think I might close this pull request and keep the alternative implementation of your feature described above. |
No description provided.