feat: added strong integer #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
approved these changes
Feb 12, 2025
README.md
Outdated
| @@ -711,7 +711,7 @@ CoolConfig.new.port == "443" #=> true | |||
|
|
|||
| **IMPORTANT**: Values provided explicitly (via attribute writers) are not coerced. Coercion is only happening during the load phase. | |||
|
|
|||
| The following types are supported out-of-the-box: `:string`, `:integer`, `:float`, `:date`, `:datetime`, `:uri`, `:boolean`. | |||
| The following types are supported out-of-the-box: `:string`, `:integer`, `:integer!`, `:float`, `:date`, `:datetime`, `:uri`, `:boolean`. | |||
There was a problem hiding this comment.
Can we add some note on what's the difference between :integer and :integer!?
palkan
reviewed
Feb 12, 2025
Nvm, I've fixed this. Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
There was a need for a more secure conversion to a integer type
What changes did you make? (overview)
Added new integer type
Checklist