Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Update procedure form to include body site #33

Merged
merged 5 commits into from
Apr 19, 2024
Merged

(feat) Update procedure form to include body site #33

merged 5 commits into from
Apr 19, 2024

Conversation

agesa3
Copy link
Contributor

@agesa3 agesa3 commented Apr 16, 2024

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Screenshot 2024-04-16 at 14 42 50

Related Issue

Other

jecihjoy
jecihjoy approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@jecihjoy jecihjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @agesa3 was this requested by the BA, if yes we can try to make it a selectable list which can pick of a concept set

@agesa3
Copy link
Contributor Author

agesa3 commented Apr 16, 2024

Hi @agesa3 was this requested by the BA, if yes we can try to make it a selectable list which can pick of a concept set

Hi @jecihjoy Ive been guided that we just have the body site as free text.

@jecihjoy jecihjoy requested a review from ojwanganto April 17, 2024 21:04
@jecihjoy
Copy link
Contributor

I will defer this to @ojwanganto to help advice whether we need three different sections (body site, additional instructions and comments to fulfiller) for captuire procedure ordering information

ojwanganto
ojwanganto requested changes Apr 18, 2024
View reviewed changes
src/form/procedures-orders/add-procedures-order/procedures-order-form.component.tsx
@@ -92,6 +92,10 @@ export function ProceduresOrderForm({
) || {}
).required;

const {
items: { answers: bodySiteItems },
} = useConceptById("162668AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a config for this?

@ojwanganto
Copy link
Contributor

@donaldkibet - please re-review this.

donaldkibet
donaldkibet approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agesa3 LGTM

@donaldkibet donaldkibet changed the title cleaned the procedure order form (feat) Update procedure form to include body site Apr 18, 2024
@ojwanganto
Copy link
Contributor

So my thoughts are:
body site: is the target body part for the procedure,
additional instructions: this is instructions about the procedure and
comments to fulfiller: is anything you would want to communicate to the person handling the procedure

@jecihjoy - do you see conflicts?

@jecihjoy
Copy link
Contributor

So my thoughts are: body site: is the target body part for the procedure, additional instructions: this is instructions about the procedure and comments to fulfiller: is anything you would want to communicate to the person handling the procedure

@jecihjoy - do you see conflicts?

Makes sense, we can proceed with the changes

@njorocs njorocs merged commit 3ea7dac into palladiumkenya:main Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojwanganto ojwanganto ojwanganto requested changes

@donaldkibet donaldkibet donaldkibet approved these changes

@jecihjoy jecihjoy jecihjoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agesa3 @jecihjoy @ojwanganto @donaldkibet @njorocs